RubyLS solution #13
Open
RubyLS solution #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic tests passing. Project structure taking form. Thinking of refactoring the permissions implementation.
interesting evolution of Permissions class. Next step is eliminating duplication between the #component_fields and #permitted_operations methods.
In order to make the column line up, each entry needs to share some knowledge related to the byte counts of other entries. I probably need to refactor this a bit and make clearer distinctions between code that parses trees (figures out what files/directories will be listed) and code that formats for display.
Defining private attr_readers does nothing but obscure what's going on. Using instance variables directly within the class gives a nice visual reminder of where these values came from.
Rename and make some small adjustments to accomodate unit testing.
|
Nice work! Code looks clean to me, but if you have any specific questions let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fun. Implementing the permissions display was particularly interesting.
I made some adjustments to my original implementation to accommodate the unit tests in this solution.
Interested in any feedback.