Fix Selector.all scope #214
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #213
So far I've added tests to map this behaviour, of which the interesting one related to #213 fails (L201-214).
It seems
Selector.all [...]delegates the list back toSelector.Internal.queryAll, which allows finding the child selector anywhere in the tree.This goes against our assumption in Elm Slack:
It might be that🅰️ the behaviour of 🅱️
Selector.allis correct and our assumption was wrongor
Selector.allis wrong and we need to make a breaking change in behaviour.Or maybe there is a way to add some new
all-like primitive that will not allow mixing nesting levels, thus not a breaking change.