Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enable Elmish apps in React components instead of full programs #42

Closed
wants to merge 1 commit into from

Conversation

alfonsogarciacaro
Copy link
Contributor

Fable.React includes a way to create React components as if they were mini-Elmish apps but I think not many people uses it.

There's a PR that's been open for a long time to make this ability more powerful by adding Elmish commands. However, I've been reluctant to merge it because it adds a dependency to Fable.Elmish and I'd like to keep those packages independent.

If we want to create mini Elmish apps using React components instead of full programs (to make them composable), maybe this should be a feature of this package instead? What do you think? @et1975 @MangelMaxime @vbfox

I haven't really tested the code, I'm just opening the PR for discussion.

@et1975
Copy link
Member

et1975 commented Jun 11, 2019

As I've mentioned in that discussion, I'm in the Separate Library camp - conceptually, this looks more like extension to React than extension to Elmish (which is what this package is for). Even if it's just 1 F# file, one could import it as github dependency with paket.

@MangelMaxime
Copy link
Member

Same here, I think it's place is in a separate library.

@alfonsogarciacaro
Copy link
Contributor Author

Ups, sorry @et1975 missed your comment in the other discussion 😅 Ok, I'll close this one and we can publish a separate library if necessary 👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants