Skip to content
This repository has been archived by the owner on Nov 11, 2023. It is now read-only.

File Upload #20

Closed
elrido opened this issue Sep 3, 2015 · 4 comments
Closed

File Upload #20

elrido opened this issue Sep 3, 2015 · 4 comments
Assignees
Milestone

Comments

@elrido
Copy link
Owner

elrido commented Sep 3, 2015

There are various file upload forks around. Integrate one of them. Some suggestions in #16 were:

@elrido elrido self-assigned this Sep 3, 2015
@elrido elrido added this to the Release 0.21 milestone Sep 3, 2015
@elrido
Copy link
Owner Author

elrido commented Sep 16, 2015

done:

  • merge of main commit containing the file upload
  • added configuration option, for now by default off
  • added messages to translation files, translated german

still to do:

  • implement it on bootstrap template
  • find a way to keep the filename on the downloaded file if possible
  • compare solution with @vikstrous later commits, some might have further improvements of the feature
  • more testing (mobile support, write unit tests, etc.)

@elrido
Copy link
Owner Author

elrido commented Sep 18, 2015

found two issues:

  • when only an attachment was posted but no text, the decryption fails
  • when binary data is sent, in some cases one has to store the file with the proper file ending to be able to open it. Might be resolved if we can keep the file name in the data URL.

@elrido
Copy link
Owner Author

elrido commented Sep 18, 2015

Note for a nice to have feature:

  • if the file is an image mime type, it would be nice if it is displayed using an img-tag instead of an anchor to download it (maybe keep to anchor for download purposes).

@elrido
Copy link
Owner Author

elrido commented Sep 18, 2015

To my (positive) surprise the file upload and display as image (and download) even works well on an iPhone (tested with bootstrap template).

Did not find any commits that seemed to add functionality or fixing things related to the file upload and will therefore close this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant