Uninterpreted functions and interactive solving #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comparison to x != y which must use not(x == y) due to the way != is defined in Julia.
…fixed save() to use IO like sat! and added options for start and end commands to enable adding (get-info) etc.
UninterpretedFunctions
2. adding options to get and set solver options, push and pop for interactive mode. All tests pass; no concurrency bugs introduced to my knowledge.
1. Added InteractiveSolver object which corrals the Base.Process and its pipes, along with a command_history. 2. Added open() and close() methods to open and close an InteractiveSolver process from a Solver. 3. Added assert!, sat!(interactive_solver, exprs...), push and pop. This allows the instantiation of an interactive solver, pushing and popping assertion levels, and equivalent behavior to check-sat-assuming. 4. Cleaned up docstrings and usage for parse_model and assign!, which are now user-facing to enable processing the results of low-level interactions with InteractiveSolvers. 5. Discovered some trouble with Base.process Pipes, see Julia issue 24717 and 24526. So I can't make (get-option) or (set-option) work right now due to problems receiving the solver response.
interactive behavior, including documentation.
@uninterpreted_func, generator syntax for and(), or(), distinct(), etc. distinct(x,y) and x != y now do the same thing, when previously x != y generated the SMT-LIB expression (not (= x y)) instead of (distinct x y).
@uninterpreted_func, generator syntax for and(), or(), distinct(), etc. distinct(x,y) and x != y now do the same thing, when previously x != y generated the SMT-LIB expression (not (= x y)) instead of (distinct x y).
-functions. This generates smaller SMT files and models, thus allowing faster solve times.
functions and solving is faster with z3. All tests pass and all examples run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@uNinterpreted macro introduces uninterpreted functions
Interact with an open SMT solver using the InteractiveSolver struct and new methods
assert!,push!andpop!(push and pop the solver assertion stack),assign!(to propagate a satisfying assignment to expressions), andsat!(interactive_solver, exprs...). When exprs are provided insat!(interactive_solver), this is equivalent to the SMT-LIB(check-sat-assuming exprs...)command.