Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 fix: use correct uppercase http verbs #68

Closed
wants to merge 1 commit into from

Conversation

m1212e
Copy link

@m1212e m1212e commented Mar 21, 2024

By standard the "PATCH" HTTP verb is not normalized: https://fetch.spec.whatwg.org/#example-normalization
This leads to very hard to debug errors in some scenarios. The small change capitalizes all HTTP verbs to prevent these kinds of errors.

@jimmy-guzman
Copy link
Contributor

@m1212e I opened #66 which accomplishes the same thing. Let's just keep one opened. I can close mine if you want to keep yours opened.

@m1212e
Copy link
Author

m1212e commented Mar 21, 2024

Ah, didn't see that. Thanks for notifying, I'll close mine. Hopefully @SaltyAom will merge yours :D

@m1212e m1212e closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants