Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use requestPath for OpenAPI spec in Swagger Options #162

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Hazmi35
Copy link

@Hazmi35 Hazmi35 commented Oct 17, 2024

Fixes #161.

This will also work when you don't specify any prefix to Elysia but uses Traefik Middlewares to strip /api prefix too.

Fixes elysiajs#161.

This will also work when you don't specify any prefix to Elysia but uses Traefik Middlewares to strip /api prefix too.
@Hazmi35 Hazmi35 changed the title fix: use requestPath for /json fix: use requestPath for OpenAPI spec in Swagger Options Oct 17, 2024
@Hazmi35 Hazmi35 closed this Oct 19, 2024
@Hazmi35
Copy link
Author

Hazmi35 commented Oct 19, 2024

This doesn't work, swagger ui and scalar should append from the browser URL, not server.

@Hazmi35 Hazmi35 reopened this Oct 19, 2024
@Hazmi35
Copy link
Author

Hazmi35 commented Oct 19, 2024

Updated. Now this work with externally set prefix (from reverse proxy), but I'm not sure to get the root Elysia app prefix after your change in ebf0e54 where elysia-swagger creates it's own Elysia instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAPI spec wrong URL
1 participant