New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check if body is null #807

Merged

jcs090218 merged 1 commit into emacs-lsp:master from oxidase:fix/body_null

Nov 1, 2024

Contributor

oxidase commented Sep 6, 2024

I got no body in a response with success status

Sending:
{
  "command": "source",
  "arguments": {
    "sourceReference": 0
  },
  "type": "request",
  "seq": 6
}
Received:
{
  "seq": 17,
  "type": "response",
  "request_seq": 6,
  "command": "source",
  "success": true
}
#s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8125 data (seq 17 type response request_seq 6 command source success t))

and dap-mode failed with

error in process filter: Wrong type argument: hash-table-p, nil [2 times]

This is a quick fix to check if body is non-nil


          fix: check if body is null

97c4ff6

jcs090218 merged commit ee1091c into emacs-lsp:master

11 checks passed

Member

jcs090218 commented Nov 1, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet