lsp-bash: only take into account buffer-local sh-shell #4675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes (#4620) make
lsp-bash
eligible for all buffers if Emacs is launch from a bash shell. It's becausesh-shell
is a global variable and its value is set to the shell used to launch Emacs (and there is no more major-mode check inlsp-bash-check-sh-shell
).This can lead to choose the wrong server (depending on priorities). For example, if I open a typescript file, I can observe the following logs:
To fix the problem, we can reintroduce major-mode check or only take into account buffer-local
sh-shell
(as proposed by this PR). Feel free to choose the solution you prefer.