feat: UI enhancement - Custom Titlebar #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be honest the default titlebar just annoyed me, so i made a custom component to emulate it that can blend it with the UI and its colors
In the TitleBar component, this line was returning false when fullscreen is true:
return (
!fullscreen && (
// ...
)
);
Since false is not a valid JSX element, we were getting an error.
To fix this, i made sure TitleBar always returns JSX.
Stormix
requested changes
Aug 30, 2023
There was a problem hiding this comment.
First of all, thank you for your contributions to the Athan app!
But, I think you can achieve the same behavior using the packages we already have, namely: tailwind and radix-icons. So I invite you to try and refactor your code to use these packages and please leave the permissions list as detailed as it currently is (so it doesn't cause us issues when submitting to the microsoft store).
Kind Regards,
Anas
…rmissions Removed the heavy packages, re-done styling with tailwindcss, refactored permissions, refactored the TitleBar component to be optimal and efficient, fixed the SideBar that was breaking at a certain height (exactly 850px) when the view height is less than that, the Sidebar doesn't take 100% of the window height anymore, so i fixed the min-height at 850px.
|
Here is a preview of what the UI has become. |
Stormix
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest the default titlebar just annoyed me, so i made a custom component to emulate it that can blend it with the UI and its colors.