Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix probe-rs "--binary-format" -> "--format" argument in README.md #274

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

JuliDi
Copy link
Contributor

@JuliDi JuliDi commented Aug 23, 2024

In the latest version of probe-rs (23.0) the argument is now called "format". The Readme seems to be based on an older version of probe.

Helptext:

      --format <FORMAT>
          If a format is provided, use it. If a target has a preferred format, we use that. Finally, if neither of the above cases are true, we default to ELF

In the latest version of probe-rs (23.0) the argument is now called "format"
@Dirbaio Dirbaio added this pull request to the merge queue Aug 23, 2024
Merged via the queue into embassy-rs:master with commit 0c5afce Aug 23, 2024
1 check passed
@JuliDi JuliDi deleted the patch-1 branch August 23, 2024 12:22
@8cichy8
Copy link

8cichy8 commented Aug 23, 2024

This is wrong. You did reversed it to old format. This was changed in probe-rs this year. And actual version is 0.24.0 ...

@JuliDi
Copy link
Contributor Author

JuliDi commented Aug 23, 2024

Good catch, I must have missed that update (or messed up my PATH 😱)

@Dirbaio can you reverse the commit or should I make a new PR. I'm sorry for the mess!

@Dirbaio
Copy link
Member

Dirbaio commented Aug 23, 2024

reverted in 991d28e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants