Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Memory Size for STM32G4...6/8 and STM32G4[34]..B #478

Merged
merged 2 commits into from
May 14, 2024

Conversation

AdinAck
Copy link
Contributor

@AdinAck AdinAck commented May 13, 2024

The memory size for these chips was set to 20 KiB instead of 32. Perhaps a hex to dec conversion error.

Evidence that the correct size is 32 KiB:
STM32G4xxxx
STM32G441RB

Thanks!

@embassy-ci
Copy link

embassy-ci bot commented May 13, 2024

@AdinAck
Copy link
Contributor Author

AdinAck commented May 13, 2024

After looking closer at the datasheet I actually don't know how to modify the invocation of mem! to accurately represent the SRAM banks in these chips, but 20 KiB is still certainly wrong so I will change this to an issue.

@AdinAck AdinAck reopened this May 14, 2024
@embassy-ci
Copy link

embassy-ci bot commented May 14, 2024

@AdinAck
Copy link
Contributor Author

AdinAck commented May 14, 2024

woops: #301

@Dirbaio Dirbaio added this pull request to the merge queue May 14, 2024
@Dirbaio
Copy link
Member

Dirbaio commented May 14, 2024

thanks!

Merged via the queue into embassy-rs:main with commit 2973b28 May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants