Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added ModelMeta for Chinese and multilingual GTE and BGE models #1805

Closed
wants to merge 23 commits into from

Conversation

x-tabdeveloping
Copy link
Collaborator

Added meta for the following:

  • BGE:
    • small-zh-v1.5
    • base-zh-v1.5
    • large-zh-v1.5
    • multilingual-gemma2
  • GTE:
    • small-zh
    • base-zh
    • large-zh
    • multilingual-base

#1803

@x-tabdeveloping
Copy link
Collaborator Author

Sorry for the messy commit history it was an accident :(((

@x-tabdeveloping
Copy link
Collaborator Author

@isaac-chung This model loading thing doesn't work but I can't get a meaningful error message. You have an idea what's happening?

@isaac-chung
Copy link
Collaborator

@x-tabdeveloping ah I need to reopen an old issue:
System.IO.IOException: No space left on device

Copy link
Collaborator

@Samoed Samoed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! However, I believe that the previous commits may cause issues, as they are from #1765.

@x-tabdeveloping
Copy link
Collaborator Author

Hmm let's get #1765 merged before this, since it to a certain extent depends on it.

@Samoed
Copy link
Collaborator

Samoed commented Jan 15, 2025

I think you can recreate branch with only your changes

@isaac-chung
Copy link
Collaborator

@x-tabdeveloping does this branch have the latest main merged in?

@x-tabdeveloping
Copy link
Collaborator Author

I'll try to rebase on main or cherry pick my way to it, sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants