big cleanup #786
Merged
big cleanup #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of code here isn't needed anymore because we dropped support for the last ember versions that needed moduleApiPolyfill, which means we can always use babel-plugin-ember-template-compilation, which is smart enough to handle its own parallelizability.
Closed
|
I'm also dropping the "addon" APIs
|
|
Once embroider-build/embroider#1743 is out this should all pass. |
ef4
added a commit
to glimmerjs/glimmer-vm
that referenced
this pull request
Dec 24, 2023
While working toward [strict-es-modules](emberjs/rfcs#938), I found that under real ES modules, this feature-detection code will become eager, which makes it blow up inside all versions of ember-cli-htmlbars before ember-cli/ember-cli-htmlbars#786, because ember-cli-htmlbars insists on evaluating the template compiler bundle inside a VM with no valid `URL` global. While that is now fixed in an upcoming major of ember-cli-htmlbars, people can't benefit from that until their very last addon upgrades ember-cli-htmlbars. So it's also good to fix this directly, by making the feature detection code explicitly lazy.
ef4
added a commit
to glimmerjs/glimmer-vm
that referenced
this pull request
Dec 24, 2023
While working toward [strict-es-modules](emberjs/rfcs#938), I found that under real ES modules, this feature-detection code will become eager, which makes it blow up inside all versions of ember-cli-htmlbars before ember-cli/ember-cli-htmlbars#786, because ember-cli-htmlbars insists on evaluating the template compiler bundle inside a VM with no valid `URL` global. While that is now fixed in an upcoming major of ember-cli-htmlbars, people can't benefit from that until their very last addon upgrades ember-cli-htmlbars. So it's also good to fix this directly, by making the feature detection code explicitly lazy.
ef4
added a commit
to glimmerjs/glimmer-vm
that referenced
this pull request
Dec 24, 2023
While working toward [strict-es-modules](emberjs/rfcs#938), I found that under real ES modules, this feature-detection code will become eager, which makes it blow up inside all versions of ember-cli-htmlbars before ember-cli/ember-cli-htmlbars#786, because ember-cli-htmlbars insists on evaluating the template compiler bundle inside a VM with no valid `URL` global. While that is now fixed in an upcoming major of ember-cli-htmlbars, people can't benefit from that until their very last addon upgrades ember-cli-htmlbars. So it's also good to fix this directly, by making the feature detection code explicitly lazy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of code here isn't needed anymore because we dropped support for the last ember versions that needed moduleApiPolyfill, which means we can always use babel-plugin-ember-template-compilation, which is smart enough to handle its own parallelizability.