Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add code to support node 8" #1241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mansona
Copy link
Member

@mansona mansona commented Aug 10, 2023

This reverts commit 13e645c.

This is related to the note I added in #1240, essentially we had code in there with the comment // remove when node 8 is dropped and this PR just removes it.

I don't really have the context to understand why this was added 🤔 any help or guidance would be appreciated 👍

@@ -175,7 +172,7 @@ function runEmberRemotely({
let isGlimmer = blueprint.packageName === glimmerPackageName && blueprint.name === glimmerPackageName;

if (isCustomBlueprint || isGlimmer) {
args = [`ember-cli@${lastNode8Version}`, ...args];
args = ['ember-cli', ...args];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might do 'ember-cli@latest' here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I agree! that's what I did in my other PR that actually fixes the v2 addon blueprint: https://github.com/ember-cli/ember-cli-update/pull/1240/files#diff-b036a2bfff3e6c44af88056b383d9acaeb4f45c37efb5559d60ebec68250eb10L178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants