Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing patched boilerplate-update #1247

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Testing patched boilerplate-update #1247

wants to merge 5 commits into from

Conversation

ef4
Copy link

@ef4 ef4 commented Sep 5, 2023

This is #1246 plus a patch to boilerplate-update because I want to see how CI behaves.

@ef4 ef4 mentioned this pull request Sep 5, 2023
- _prepareCommand(endOptions)
- ]);
+ let startCommand = await (reset || init ? null : _prepareCommand(startOptions));
+ let endCommand = await _prepareCommand(endOptions);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this to prove that the parallelism here was causing the problem.

But I think a real fix would only disable parallelism more selectively to workaround the known bad situation (presumably when using npx on windows) without making everybody else wait twice as long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants