fix no empty glimmer class

ember-cli · Aug 22, 2023 · 8c5a5cf · 8c5a5cf
1 parent 58328dc
commit 8c5a5cf
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/lib/rules/no-empty-glimmer-component-classes.js b/lib/rules/no-empty-glimmer-component-classes.js
@@ -1,7 +1,6 @@
 'use strict';
 
 const { isGlimmerComponent } = require('../utils/ember');
-const { isClassPropertyOrPropertyDefinition } = require('../utils/types');
 
 const ERROR_MESSAGE = 'Do not create empty backing classes for Glimmer components.';
 const ERROR_MESSAGE_TEMPLATE_TAG =
@@ -40,8 +39,7 @@ module.exports = {
           context.report({ node, message: ERROR_MESSAGE });
         } else if (
           node.body.body.length === 1 &&
-          (isClassPropertyOrPropertyDefinition(node.body.body[0]) ||
-            node.body.body[0].type === 'GlimmerTemplate') &&
+          node.body.body[0].type === 'GlimmerTemplate' &&
           !subClassHasTypeDefinition
         ) {
           context.report({ node, message: ERROR_MESSAGE_TEMPLATE_TAG });

diff --git a/tests/lib/rules/no-empty-glimmer-component-classes.js b/tests/lib/rules/no-empty-glimmer-component-classes.js
@@ -55,6 +55,16 @@ ruleTester.run('no-empty-glimmer-component-classes', rule, {
       code: `
         import Component from '@glimmer/component';
 
+        export default class MyComponent extends Component {
+          property = '';
+        }
+      `,
+      parser: require.resolve('@typescript-eslint/parser'),
+    },
+    {
+      code: `
+        import Component from '@glimmer/component';
+
         export interface SomeSig {}
         export interface SomeOtherSig {}