-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add requireArgs
option in require-super-in-lifecycle-hooks
rule
#1836
Open
samridhivig
wants to merge
6
commits into
ember-cli:master
Choose a base branch
from
samridhivig:update-require-super-in-lifecycle-hooks-rule
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4d79934
make sure the init hook is called with arguments
ef63805
add some test cases
a151791
fix bug in hasSuperWithArguments logic
14a5398
add requireArgs option
088a404
update documentation with the new requireArgs option
c922dc3
resolve PR feeback
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -231,6 +231,19 @@ eslintTester.run('require-super-in-lifecycle-hooks', rule, { | |
|
||
// Does not throw with node type (ClassProperty) not handled by estraverse. | ||
'Component.extend({init() { class Foo { @someDecorator() someProp }; return this._super(...arguments); } });', | ||
|
||
// init hook should not be checked for arguments when requireArgs = false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's include a test case for both:
|
||
`import Service from '@ember/service'; | ||
class Foo extends Service { | ||
init() { | ||
super.init(); | ||
} | ||
}`, | ||
`export default Component.extend({ | ||
init() { | ||
this._super(...arguments); | ||
}, | ||
});`, | ||
], | ||
invalid: [ | ||
{ | ||
|
@@ -858,5 +871,73 @@ super.didInsertElement(...arguments);} | |
options: [{ checkNativeClasses: true, checkInitOnly: false }], | ||
errors: [{ message, line: 3 }], | ||
}, | ||
|
||
// init hooks shoudn't call super without ...arguments | ||
{ | ||
code: `import Service from '@ember/service'; | ||
class Foo extends Service { | ||
init() { | ||
super.init(); | ||
} | ||
}`, | ||
output: `import Service from '@ember/service'; | ||
class Foo extends Service { | ||
init() { | ||
super.init(...arguments); | ||
} | ||
}`, | ||
options: [{ requireArgs: true }], | ||
errors: [{ message, line: 3 }], | ||
}, | ||
{ | ||
code: `import Service from '@ember/service'; | ||
class Foo extends Service { | ||
init() { | ||
super.init(); | ||
console.log(); | ||
} | ||
}`, | ||
output: `import Service from '@ember/service'; | ||
class Foo extends Service { | ||
init() { | ||
super.init(...arguments); | ||
console.log(); | ||
} | ||
}`, | ||
options: [{ requireArgs: true }], | ||
errors: [{ message, line: 3 }], | ||
}, | ||
{ | ||
code: `export default Component.extend({ | ||
init() { | ||
this._super(); | ||
}, | ||
});`, | ||
output: `export default Component.extend({ | ||
init() { | ||
this._super(...arguments); | ||
}, | ||
});`, | ||
options: [{ requireArgs: true }], | ||
errors: [{ message, line: 2 }], | ||
}, | ||
{ | ||
code: `export default Component.extend({ | ||
init() { | ||
this._super(); | ||
this.set('prop', 'value'); | ||
this.set('prop2', 'value2'); | ||
}, | ||
});`, | ||
output: `export default Component.extend({ | ||
init() { | ||
this._super(...arguments); | ||
this.set('prop', 'value'); | ||
this.set('prop2', 'value2'); | ||
}, | ||
});`, | ||
options: [{ requireArgs: true }], | ||
errors: [{ message, line: 2 }], | ||
}, | ||
], | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid searching for the node again? We should already have it from the above
hasMatchingNode
call right, so we can just check if that node has arguments.