fix some pages not loading #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patricklx can you please explain this some more? I do not understand when this is an issue. The render performance page works for me without this. Is this if apps are using embroider or something? |
|
@rwwagner90 sorry, I mean this is not working in the current main branch and can be seen with the nightly build on chrome: https://chrome.google.com/webstore/detail/ember-inspector-nightly/ibdbkmdgflhglikhjdbogjjflkialpfi |
|
|
|
also, if you look at the generated index.html script src: <body class="ember-application theme--light">
<script src="assets/vendor.js"></script>
<script src="/assets/chunk.131.94e9295903c351885e48.js"></script>
<script src="/assets/chunk.143.2f2438030067e3bf00af.js"></script>
<script src="assets/ember-inspector.js"></script>
...
</body> |
RobbieTheWagner
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. render performance page did not load and possibly other issues
because chunks of webpack where not loaded since url was wrong
embroider-build/ember-auto-import#540