Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make release-able by fixing repository in package.json #80

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

chriskrycho
Copy link
Contributor

Without this:

ERROR npm warn publish npm auto-corrected some errors in your package.json when publishing.  Please run "npm pkg fix" to address these errors.

Doing so results in this change.

@chriskrycho
Copy link
Contributor Author

@jrjohnson before we release this, I think it needs some basic maintenance—probably mostly just a bunch of dep updates. I am happy to take a little time to review that kind of maintenance PR, so feel free to ping me—but we should definitely do that before trying to release this, because we will otherwise likely just be foisting these exact issues on downstream consumers. Going to mark this particular PR as blocked until that’s the case, and we also will not be able to do a release until then!

Without this:

```
ERROR npm warn publish npm auto-corrected some errors in your package.json when publishing.  Please run "npm pkg fix" to address these errors.
```

Running `npm pkg fix` results in this change.
@chriskrycho chriskrycho merged commit a19d261 into master Dec 22, 2024
9 checks passed
@chriskrycho
Copy link
Contributor Author

@jrjohnson this landed; anything else you think should be done before releasing a v3.0.0? (I’m not in a hurry, it can be tomorrow or later this week!)

@chriskrycho chriskrycho deleted the make-release-able branch December 22, 2024 21:42
@jrjohnson
Copy link
Contributor

I think this is ready for v3 release.
I'll follow up with a switch to pnpm and then see where that leave #66 and the move to a v2 addon (which may be unlocked with the blueprint updates, or pnpm). I think both of those are a good candidate for a second breaking major 4.0.0 just to spread things out if that's ok with you.

@chriskrycho
Copy link
Contributor Author

@jrjohnson I infer your thinking here is that way people on Ember v6 could upgrade to ember-render-modifiers v3 even if they’re not ready to consume a v2 addon, and then once they are, go ahead and upgrade to ember-render-modifiers v4? Assuming so, that seems reasonable to me. Once you confirm, I’ll do a release. 👍🏼

@jrjohnson
Copy link
Contributor

Oooh that too 😁, I was just worried about too much change all in one release. But we absolutely should have a release for non-v2-addon, but yes Ember 6, apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants