Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] allow modifier helper to resolve built-ins like on #20629

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[bugfix] allow modifier helper to resolve built-ins like on #20629

wants to merge 1 commit into from
+28 −1

Commits on Jan 24, 2024

  1. [bugfix] allow modifier to resolve built-ins like on 

    partially fixes emberjs#19869

Due to [GlimmerVM's assertion][1], this still does not fix the issue in
strict mode. We also can't work around the strict mode limitation with
an AST transform since Glimmer's transforms run first.

[1]: https://github.com/glimmerjs/glimmer-vm/blob/2ddbbc4a9b97db4f326c4d92021f089c464ab093/packages/%40glimmer/compiler/lib/passes/1-normalization/keywords/utils/curry.ts#L53
    @fivetanley
    fivetanley committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    834da17 View commit details
    Browse the repository at this point in the history