Add some TS component blueprint tests #20771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windvis
commented
Oct 5, 2024
| importers: | ||
|
|
||
| .: | ||
| dependencies: | ||
| '@babel/core': | ||
| specifier: ^7.24.4 | ||
| version: 7.24.4 | ||
| version: 7.24.4([email protected]) |
There was a problem hiding this comment.
There are a lot of lock changes, but I used the pnpm version that was listed in the package.json (8.10). I guess it's possible someone else used a different version in the past?
|
Hmm, I think CI isn't using the pnpm patch. It does seem to work locally, so not sure what I did wrong. 🤔 Edit: Ah no, I forgot about the blueprint tests that mimic the scenario where .ts can't be transpiled (so the |
Windvis
force-pushed
the
ts-blueprint-tests
branch
2 times, most recently
from
c992cd1
to
70fc841
Compare
Windvis
commented
Oct 5, 2024
Windvis
force-pushed
the
ts-blueprint-tests
branch
from
70fc841
to
bdf2e75
Compare
Windvis
commented
Oct 5, 2024
Windvis
force-pushed
the
ts-blueprint-tests
branch
from
f8d59f1
to
dff3a4f
Compare
Windvis
changed the title
Windvis
commented
Oct 6, 2024
This setup can verify that the .ts blueprints are working as expected.
This fixes an issue where `.ts.ts` or `.ts.hbs` would be generated if the user added the extension to the cli command: `ember g component foo.ts`
Windvis
force-pushed
the
ts-blueprint-tests
branch
from
dff3a4f
to
f41d8ae
Compare
Windvis
commented
Oct 7, 2024
| "test:blueprints:js": "EMBER_TYPESCRIPT_BLUEPRINTS=false pnpm test:blueprints:js-from-ts", | ||
| "test:blueprints:js-from-ts": "mocha node-tests/blueprints/**/*-test.js", | ||
| "test:blueprints:ts": "mocha node-tests/blueprints-ts/**/*-test.js", | ||
| "test:blueprints": "npm-run-all test:blueprints:*", |
There was a problem hiding this comment.
We can remove this one now since we no longer use it in CI, and I don't expect anyone to run all of them like this locally either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into #20511 I noticed there weren't any tests for the
--typescriptversion of the blueprints.This adds a some ts tests for the component blueprint. We can add tests for other blueprint in follow up PRs.
I included a pnpm patch for the
ember-cli/ember-cli-blueprint-test-helperspackage since it doesn't accept any extra cli arguments forember newin its current state: ember-cli/ember-cli-blueprint-test-helpers#391This also fixes a bug where
ember g component foo.tswould generate.ts.hbsfiles since .ts wasn't normalized yet.Partially solves: #20362