Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds EmbraceConfigurable. Allows Option to be passed in when app_id not present to override EmbraceConfig behavior #56

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Adds EmbraceConfigurable. Allows Option to be passed in when app_id not present to override EmbraceConfig behavior #56

wants to merge 14 commits into from

Commits on Sep 26, 2024

  1. WIP - Initial refactor of config to separate EmbraceConfigurable pr… 

    …otocol with different implementations, RemoteConfig and DefaultConfig
    @atreat
    atreat committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a0db855 View commit details
    Browse the repository at this point in the history

  2. Updates RemoteConfigFetcherTests 

    Pulls responsibility from EmbraceConfigTests
    @atreat
    atreat committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    97570d2 View commit details
    Browse the repository at this point in the history

  3. Adds RemoteConfigTests to test EmbraceConfigurable implementation 

    Also tests logic around enabling config based on device_id + configured threshold
    @atreat
    atreat committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    8e84602 View commit details
    Browse the repository at this point in the history

  4. Updates RemoteConfigTests with addition of NetworkPayloadCaptureRule

    @atreat
    atreat committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    8e46e92 View commit details
    Browse the repository at this point in the history

  5. Adds tests and updates docC

    @atreat
    atreat committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    cb1ac17 View commit details
    Browse the repository at this point in the history

  6. Adds updated EmbraceConfigTests to check for updateIfNeeded behavior … 

    …and delegation to underlying EmbraceConfigurable implementation
    @atreat
    atreat committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    bed0560 View commit details
    Browse the repository at this point in the history

  7. Creates new target EmbraceConfiguration. 

    This is separate from `EmbraceConfigInternal` (it is a dependency there)

This target is meant for those that would like to inject an `EmbraceConfigurable` implementation into the `Embrace.Options` when setting up the Embrace instance.
    @atreat
    atreat committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    b6c6647 View commit details
    Browse the repository at this point in the history

  8. Adds EmbraceConfiguration target to build_xcframeworks script, Proj… 

    …ect.swift, and podspec template
    @atreat
    atreat committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    975bb08 View commit details
    Browse the repository at this point in the history

  9. Updates EmbraceConfigurable.update method to take completion handler 

    This is used to post `embraceConfigUpdated` notification
    @atreat
    atreat committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d9d5e79 View commit details
    Browse the repository at this point in the history

  10. Updates RemoteConfig to have public initializer not require the inter… 

    …nal RemoteConfigFetcher
    @atreat
    atreat committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3b2d2f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Update Sources/EmbraceConfigInternal/EmbraceConfigurable/RemoteConfig… 

    …/RemoteConfigFetcher.swift

Co-authored-by: ArielDemarco <[email protected]>
    @atreat @ArielDemarco
    atreat and ArielDemarco authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8a4225a View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Fixes tests after change to query items

    @atreat
    atreat committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    8fbb200 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into atreat/embrace-configurable

    @atreat
    atreat authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    3a52c52 View commit details
    Browse the repository at this point in the history

  3. Updates SessionControllerTests after merge from main

    @atreat
    atreat committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4cf5fb8 View commit details
    Browse the repository at this point in the history