Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates EmbraceSemantics to move definitions under SpanEventType #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atreat
Copy link
Contributor

@atreat atreat commented Sep 18, 2024

These were incorrectly defined under SpanType. They are created/added to items that we record as SpanEvents.

@atreat atreat self-assigned this Sep 18, 2024
@atreat atreat requested a review from a team as a code owner September 18, 2024 17:29
Copy link

Copy link

github-actions bot commented Sep 18, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Sep 18, 2024

Warnings
⚠️ No CHANGELOG entry added.
⚠️ No tests added / modified.
⚠️

Sources/EmbraceCore/Capture/UX/Tap/TapCaptureService.swift#L137 - Returning Void in a function declaration is redundant (redundant_void_return)

Generated by 🚫 Danger Swift against f4e4d3f

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (52375c4) to head (ea2543a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   91.84%   91.78%   -0.06%     
==========================================
  Files         403      403              
  Lines       25931    25931              
==========================================
- Hits        23816    23802      -14     
- Misses       2115     2129      +14     
Files with missing lines Coverage Δ
...apture/System/LowMemoryWarningCaptureService.swift 100.00% <100.00%> (ø)
...EmbraceCore/Capture/UX/Tap/TapCaptureService.swift 96.19% <100.00%> (ø)
...ceCore/Capture/WebView/WebViewCaptureService.swift 80.39% <100.00%> (ø)
Sources/EmbraceCore/Public/Events/Breadcrumb.swift 100.00% <100.00%> (ø)
...blic/PushNotifications/PushNotificationEvent.swift 79.56% <100.00%> (ø)

... and 6 files with indirect coverage changes

These were incorrectly defined under `SpanType`
@atreat atreat force-pushed the atreat/formalize-span-type-EMBR-4419 branch from ea2543a to f4e4d3f Compare October 2, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant