Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded deps #6

Merged
merged 1 commit into from
May 24, 2024
Merged

Remove unneeded deps #6

merged 1 commit into from
May 24, 2024

Conversation

NullVoxPopuli
Copy link
Collaborator

Deps that are still required

  • ember-auto-import (because ember-auto-import has a check to make sure the host project has ember-auto-import)
  • ember-cli-babel -- something has to configure babel

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to get CI running a build and a test before we make changes like this

@mansona mansona dismissed their stale review May 24, 2024 21:55

CI is now running!

@mansona
Copy link
Member

mansona commented May 24, 2024

ember-cli-babel -- something has to configure babel

for now! I suspect when we're finished we won't need this 👍

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one! :shipit:

@mansona mansona added the enhancement New feature or request label May 24, 2024
@mansona mansona merged commit abe2d52 into main May 24, 2024
1 of 2 checks passed
@mansona mansona deleted the remove-more-deps branch May 24, 2024 21:57
@github-actions github-actions bot mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants