Extract an output:fixture command for manual testing #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Oct 1, 2024
|
|
||
| // apply the fixture on top of the generated app | ||
| copyWithTemplate(join(__dirname, 'fixture'), join(tmpDir.path, name), { |
There was a problem hiding this comment.
this change here was actually a bug as it didn't use the var from the caller
NullVoxPopuli
commented
Oct 1, 2024
| }); | ||
| }); | ||
|
|
||
| afterAll(async () => { | ||
| try { | ||
| await tmpDir.cleanup(); | ||
| await tmp.cleanup(); | ||
| } catch { | ||
| // if it fails to cleaup we don't want to break CI | ||
| } | ||
| }); | ||
|
|
||
| return { |
There was a problem hiding this comment.
this structure got cleaned up quite a bit because the joins and all that are now in new-app
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #80.
Will come in handy as we add more fixtures.