Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more files to the files-override/shared folder #99

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

NullVoxPopuli
Copy link
Collaborator

Doesn't affect output

@@ -2,6 +2,7 @@

module.exports = {
plugins: ['prettier-plugin-ember-template-tag'],
singleQuote: true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't you remove all the other places in this file that change singleQuote to true in the overrides now that this is setting it as the default?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope so 😅

@NullVoxPopuli NullVoxPopuli force-pushed the prepare-for-ts-via-shared-directory branch 2 times, most recently from e896171 to dcb6d7b Compare October 4, 2024 21:12
@NullVoxPopuli NullVoxPopuli force-pushed the prepare-for-ts-via-shared-directory branch from dcb6d7b to 6ab0eb1 Compare October 4, 2024 21:13
@mansona mansona changed the title Move more files to the files-override/shared folder for better sharing between variants of the blueprint (e.g.: js and ts) Move more files to the files-override/shared folder Oct 7, 2024
@NullVoxPopuli NullVoxPopuli merged commit 117c16d into main Oct 7, 2024
2 checks passed
@NullVoxPopuli NullVoxPopuli deleted the prepare-for-ts-via-shared-directory branch October 7, 2024 13:06
@github-actions github-actions bot mentioned this pull request Oct 4, 2024
@NullVoxPopuli NullVoxPopuli mentioned this pull request Oct 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants