Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error for module-resolver, maybe? #2132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Better error for module-resolver, maybe? #2132

wants to merge 1 commit into from

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Oct 1, 2024 •
edited
Loading

Saw a todo when I was poking around in #2131

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review October 1, 2024 19:11
@NullVoxPopuli NullVoxPopuli requested a review from ef4 October 2, 2024 04:54
@patricklx
Copy link
Contributor

i think it would help if all errors include the specifier & fromfile.
recently had the error an addon tried to import from "@embroider/virtual", but it,s not one of its explicit dependencies
not hepful.
it was power-select. which has peer deps, when those are not installed, that error appears

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ef4 ef4 Awaiting requested review from ef4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NullVoxPopuli @patricklx