Skip to content

Commit

Permalink
Fix TestVersion for Jackson 2.16 and 2.17
Browse files Browse the repository at this point in the history
The test has started to fail since Jackson 2.16.0 because of the following changes:

- FasterXML/jackson-core#1053
- FasterXML/jackson-core#1142

These were "fixing" the following issues:

- FasterXML/jackson-core#1050
- FasterXML/jackson-core#1141
  • Loading branch information
dmikurube committed Apr 3, 2024
1 parent 35cb6a5 commit 8e5841e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/test/java/org/embulk/util/config/TestVersion.java
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ public void testParseVersion() throws Exception {
Version.parseVersionForTesting("14.139-SNAPSHOT"));
assertEquals(new com.fasterxml.jackson.core.Version(103, 0, 0, "SNAPSHOT-A", "org.embulk", "embulk-util-config"),
Version.parseVersionForTesting("103-SNAPSHOT-A"));
assertEquals(new com.fasterxml.jackson.core.Version(5, 3, 1, "", "org.embulk", "embulk-util-config"),
assertEquals(new com.fasterxml.jackson.core.Version(5, 3, 1, null, "org.embulk", "embulk-util-config"),
Version.parseVersionForTesting("5.3.1"));
assertEquals(new com.fasterxml.jackson.core.Version(9, 8, 0, "", "org.embulk", "embulk-util-config"),
assertEquals(new com.fasterxml.jackson.core.Version(9, 8, 0, null, "org.embulk", "embulk-util-config"),
Version.parseVersionForTesting("9.8"));
assertEquals(new com.fasterxml.jackson.core.Version(4, 0, 0, "", "org.embulk", "embulk-util-config"),
assertEquals(new com.fasterxml.jackson.core.Version(4, 0, 0, null, "org.embulk", "embulk-util-config"),
Version.parseVersionForTesting("4"));

assertThrows(IllegalArgumentException.class, () -> Version.parseVersionForTesting(""));
Expand Down

0 comments on commit 8e5841e

Please sign in to comment.