Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WS connections do not honor disable-validation #159

Merged
merged 1 commit into from
May 12, 2022

Conversation

roderik
Copy link
Contributor

@roderik roderik commented May 6, 2022

I noticed that as soon as I configure a WS upstream, that the disable-validation option no longer works. This is especially annoying with some hosted WS providers that do not expose the net namespace.

I used the same logic as the RPC upstream uses.

probably fixes:

@codecov-commenter
Copy link

Codecov Report

Merging #159 (381b2d5) into master (87c1ea9) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #159      +/-   ##
============================================
- Coverage     55.30%   55.28%   -0.03%     
- Complexity     1343     1344       +1     
============================================
  Files           190      190              
  Lines          7077     7082       +5     
  Branches        859      860       +1     
============================================
+ Hits           3914     3915       +1     
- Misses         2679     2684       +5     
+ Partials        484      483       -1     
Impacted Files Coverage Δ
...y/dshackle/upstream/ethereum/EthereumWsUpstream.kt 0.00% <0.00%> (ø)
...tlin/io/emeraldpay/dshackle/rpc/TrackEthereumTx.kt 78.53% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c1ea9...381b2d5. Read the comment docs.

@splix splix merged commit 530811d into emeraldpay:master May 12, 2022
@splix
Copy link
Member

splix commented May 12, 2022

Thank you!

vdoflip pushed a commit to jit-strategies/dshackle that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants