Commits on May 13, 2023

1. Compute client waiting time without including testing framework time …

   Previously, the time to stop node threads and the time to check
   invariants was charged against any outstanding client requests'
   waiting time. Stopping a node thread requires that the node thread
   finish executing the current event handler. If the event handler has a
   performance bug, that will cause `runstate.stop()` to be slow.
   Similarly, checking invariants can be expensive for long logs.
   
   This commit introduces markEndTimeOfOutstandingRequest, which allows
   the test to set the ending time of outstanding requests *before*
   stopping threads and checking invariants. Then, after
   those (potentially expensive) operations, the tests can assert that
   the waiting time is acceptable.
   
   Unfortunately this introduces a bit of a sharp corner into the testing
   framework's internal API: it would be easy to forget to call
   markEndTimeOfOutstandingRequest before assertMaxWaitTimeLessThan.
   Perhaps we should add a check for this to help with framework
   maintenance.
   
   I also added a warning if the framework detects that `runstate.stop()`
   took longer than one second. That indicates that some event handler in
   the system took a long time to run. (This warning remains difficult to
   debug, but at least the new situation is better than the previous one.)

   

   wilcoxjay committed May 13, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 1be0092
   • Browse repository at this point

   Copy the full SHA

   1be0092 View commit details

   Browse the repository at this point in the history