Compute client waiting time without including testing framework time #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #48. |
|
This is totally untested. Will need to add some sort of testing later or at least verify by hand that this still works. @wilcoxjay for some reason I can't add you as a reviewer, but what do you think? |
|
Replaces #50. |
|
Looks great! I like this approach a lot more. |
emichael
force-pushed
the
feature/max-wait-time-computation
branch
3 times, most recently
from
5447d45
to
2f9c3e8
Compare
|
I ran into this problem again today. Can we merge this? |
emichael
force-pushed
the
feature/max-wait-time-computation
branch
from
2f9c3e8
to
ca02b92
Compare
This commit adds a private field to RunState to track when the system under test was most recently stopped. Then, when checking ClientWorkers' maximum wait times, we use that time as the basis for computing the maximum wait time. Co-authored-by: James Wilcox <[email protected]>
emichael
force-pushed
the
feature/max-wait-time-computation
branch
from
ca02b92
to
64e99a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a private field to RunState to track when the system under test was most recently stopped. Then, when checking ClientWorkers' maximum wait times, we use that time as the basis for computing the maximum wait time.
This is a modification of @wilcoxjay's original fix, but I think it's a little bit cleaner to not force every test to call a specific method before calling
assertMaxWaitTimeLessThan.