-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added translate function to lyrics #82
base: master
Are you sure you want to change the base?
Conversation
Hello @renatonolo thanks for submiting this PR. I've merged it and resolved conflicts with last master in this branch: https://github.com/emilioastarita/lyricfier/tree/translated-lyrics . I think that needs some work before to be merged on master. Do you want to work on it?
Thanks! If you need any help let me kwnow. |
…ate to lyrics. Updated to use checkbox instead select to keep in the same design from Keep Lyricfier always on top.
…on Translate lyrics button.
Hello man. I'm back. I saw your suggestions and I liked. Then, I already did the modifications, according your suggestions. Can you see and analyze that to merge or not this modifications? If you have questions, ask me.. 👍 |
Ok I would check about API_KEY if this is private or not. Usually this could be a problem because multiple users share the same credentials so you hit soon to the rate limits of the APIs. Can you provide a link where I can investigate about TOS and conditions of the provider? |
Yeah, you can see the documentation on: https://api.vagalume.com.br/docs/ |
This commit add a translate button to song screen, allowing the users to translate the lyrics.
To this button appear on song screen, you need to enable translate on Settings screen and choose a language to translate.
You can improve this function, creating TranslatePlugins, to get translated songs from another sources..
Please, analyze this and, if you have douts or questions, ask me, then we can solve the problems together.
Thanks.