Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index.html links to manifest and apple-touch-icon #142

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix index.html links to manifest and apple-touch-icon #142

merged 1 commit into from
Jun 27, 2024

Conversation

Its-Just-Nans
Copy link
Contributor

@Its-Just-Nans Its-Just-Nans commented Jun 26, 2024 •
edited
Loading

Bug: assets have incorrect paths

Proof:

git clone https://github.com/emilk/eframe_template.git && lychee .

  31/31 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links                                                                                              Issues found in 1 input. Find details below.

[./eframe_template/index.html]:
✗ [ERR] file:///tmp/tmp.xuDXKdo4H8/eframe_template/icon_ios_touch_192.png | Failed: Cannot find file
✗ [ERR] file:///tmp/tmp.xuDXKdo4H8/eframe_template/manifest.json | Failed: Cannot find file

🔍 31 Total (in 0s) ✅ 29 OK 🚫 2 Errors

Fix

change links to these assets

Related to

@emilk emilk changed the title Fix links to assets Fix index.html links to manifest and apple-touch-icon Jun 27, 2024
@emilk
Copy link
Owner

emilk commented Jun 27, 2024

Thanks!

@emilk emilk merged commit f774883 into emilk:main Jun 27, 2024
12 of 13 checks passed
@jnises
Copy link

jnises commented Jul 15, 2024

After this commit I get this warning when trying to use eframe_template with trunk: Manifest: Line: 1, column: 1, Syntax error.

Looks to me like trunk (0.20.2) copies files specified using <link data-trunk rel="copy-file" href=" to the root of the dist directory.
So prepending assets/ to the manifest.json url breaks things.

@Its-Just-Nans Its-Just-Nans mentioned this pull request Jul 15, 2024
Merged
@Its-Just-Nans
Copy link
Contributor Author

After this commit I get this warning when trying to use eframe_template with trunk: Manifest: Line: 1, column: 1, Syntax error.

Looks to me like trunk (0.20.2) copies files specified using <link data-trunk rel="copy-file" href=" to the root of the dist directory. So prepending assets/ to the manifest.json url breaks things.

Thanks for reporting it

emilk pushed a commit that referenced this pull request Jul 16, 2024
@Its-Just-Nans
Fix assets (#146)
18a8e76 
Fix
#142 (comment)

Note that only 

```
    <link rel="manifest" href="assets/manifest.json">
    <link rel="apple-touch-icon" href="assets/icon_ios_touch_192.png">
```

are really used in the final `index.html`
Hasenfellvy added a commit to Hasenfellvy/eframe_template that referenced this pull request Aug 27, 2024
@Hasenfellvy
Fix assets (#146)
b2d4c2b 
Fix
emilk/eframe_template#142 (comment)

Note that only 

```
    <link rel="manifest" href="assets/manifest.json">
    <link rel="apple-touch-icon" href="assets/icon_ios_touch_192.png">
```

are really used in the final `index.html`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Its-Just-Nans @emilk @jnises