Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm Chart Support for Opt-In Support for Exposing Port 8878 in the AdminService #5731

Merged
merged 2 commits into from
Aug 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions charts/emissary-ingress/templates/admin-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ spec:
{{- if (and (eq .Values.adminService.type "NodePort") (not (empty .Values.adminService.nodePort))) }}
nodePort: {{ int .Values.adminService.nodePort }}
{{- end }}
{{- if .Values.adminService.goPluginMetricsPort}}
- port: {{ .Values.adminService.goPluginMetricsPort }}
targetPort: 8878
protocol: TCP
name: go-plugin-filter-metrics
{{- end }}
- port: {{ .Values.adminService.snapshotPort }}
targetPort: 8005
protocol: TCP
Expand Down
8 changes: 8 additions & 0 deletions charts/emissary-ingress/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -215,11 +215,19 @@ spec:
{{- end}}
- name: admin
containerPort: {{ .Values.adminService.port }}
{{- if .Values.adminService.goPluginMetricsPort}}
- name: go-plugin-metrics-port
containerPort: {{ .Values.adminService.goPluginMetricsPort}}
{{- end}}
env:
- name: HOST_IP
valueFrom:
fieldRef:
fieldPath: status.hostIP
{{- if .Values.adminService.goPluginMetricsPort}}
- name: ENABLE_PLUGIN_FILTER_METRICS
value: "true"
{{- end }}
{{- if .Values.prometheusExporter.enabled }}
- name: STATSD_ENABLED
value: "true"
Expand Down
1 change: 1 addition & 0 deletions charts/emissary-ingress/values.yaml.in
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ adminService:
type: ClusterIP
port: 8877
snapshotPort: 8005
goPluginMetricsPort:
# If explicit NodePort for admin service is required
nodePort:
# Annotations to apply to Ambassador admin service
Expand Down
Loading