2.2.2 release

CHANGELOG.md

@@ -2,6 +2,14 @@
 
 The following is a curated list of changes in the Enact project, newest changes on the top.
 
+## [2.2.2] - 2018-10-15
+
+### Fixed
+
+- `core/util.Job` to cancel existing scheduled `idle()` jobs before scheduling another
+- `moonstone/Scroller` stuttering when page up/down key is pressed
+- `ui/Scroller` slowed scrolling behavior when repeatedly requesting a scroll to the same position
+
 ## [2.2.1] - 2018-10-09
 
 ### Fixed

lerna.json

@@ -1,6 +1,6 @@
 {
   "lerna": "2.8.0",
-  "version": "2.2.1",
+  "version": "2.2.2",
   "command": {
     "bootstrap": {
       "npmClientArgs": [

package.json

@@ -1,6 +1,6 @@
 {
   "name": "enact",
-  "version": "2.2.1",
+  "version": "2.2.2",
   "description": "Monorepo for all Enact front end libraries.",
   "private": true,
   "scripts": {

packages/core/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 The following is a curated list of changes in the Enact core module, newest changes on the top.
 
+## [2.2.2] - 2018-10-15
+
+### Fixed
+
+- `core/util.Job` to cancel existing scheduled `idle()` jobs before scheduling another
+
 ## [2.2.1] - 2018-10-09
 
 No significant changes.

packages/core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@enact/core",
-  "version": "2.2.1",
+  "version": "2.2.2",
   "description": "Enact is an open source JavaScript framework containing everything you need to create a fast, scalable mobile or web application.",
   "main": "index.js",
   "scripts": {

packages/core/util/Job.js

@@ -147,14 +147,13 @@ class Job {
 	 * @public
 	 */
 	idleUntil = (timeout, ...args) => {
-		if (typeof window !== 'undefined') {
-			if (window.requestIdleCallback) {
-				this.type = 'idle';
-				this.id = window.requestIdleCallback(() => this.run(args), {timeout});
-			} else {
-				// If requestIdleCallback is not supported just run the function immediately
-				this.fn(...args);
-			}
+		if (typeof window !== 'undefined' && window.requestIdleCallback) {
+			this.stop();
+			this.type = 'idle';
+			this.id = window.requestIdleCallback(() => this.run(args), {timeout});
+		} else {
+			// since we can't request an idle callback, just pass to startAfter()
+			this.startAfter(timeout, ...args);
 		}
 	}
 

packages/core/util/tests/Job-specs.js

@@ -81,6 +81,24 @@ describe('Job', function () {
 	});
 
 	describe('#idle', function () {
+		// polyfill for PhantomJS to verify expected idle behavior as much as possible
+		const windowRequest = window.requestIdleCallback;
+		const windowCancel = window.cancelIdleCallback;
+
+		before(() => {
+			window.requestIdleCallback = windowRequest || function (fn) {
+				return setTimeout(fn, 0);
+			};
+			window.cancelIdleCallback = windowCancel || function (id) {
+				clearTimeout(id);
+			};
+		});
+
+		after(() => {
+			window.requestIdleCallback = windowRequest;
+			window.cancelIdleCallback = windowCancel;
+		});
+
 		it('should start job', function (done) {
 			const j = new Job(done, 10);
 			j.idle();
@@ -99,5 +117,18 @@ describe('Job', function () {
 			const j = new Job(fn, 10);
 			j.idle(value);
 		});
+
+		it('should clear an existing job id before starting job', function (done) {
+			const fn = function (arg) {
+				if (arg === 'first') {
+					done(new Error('First job ran'));
+				} else {
+					done();
+				}
+			};
+			const j = new Job(fn);
+			j.idle('first');
+			j.idle('second');
+		});
 	});
 });

packages/i18n/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 The following is a curated list of changes in the Enact i18n module, newest changes on the top.
 
+## [2.2.2] - 2018-10-15
+
+No significant changes.
+
 ## [2.2.1] - 2018-10-09
 
 ### Fixed

packages/i18n/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@enact/i18n",
   "main": "./src/index.js",
-  "version": "2.2.1",
+  "version": "2.2.2",
   "description": "Internationalization support for Enact using iLib",
   "scripts": {
     "clean": "enact clean",
@@ -34,7 +34,7 @@
     "extends": "enact/strict"
   },
   "dependencies": {
-    "@enact/core": "^2.2.1",
+    "@enact/core": "^2.2.2",
     "prop-types": "^15.6.0",
     "ramda": "^0.24.1",
     "react": "^16.3.2",

packages/moonstone/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 The following is a curated list of changes in the Enact moonstone module, newest changes on the top.
 
+## [2.2.2] - 2018-10-15
+
+### Fixed
+
+- `moonstone/Scroller` stuttering when page up/down key is pressed
+
 ## [2.2.1] - 2018-10-09
 
 ### Fixed

packages/moonstone/ExpandableList/tests/ExpandableList-specs.js

@@ -21,7 +21,7 @@ describe('ExpandableList', () => {
 		const children = ['option1', 'option2', 'option3'];
 
 		const expandableList = mount(
-			<ExpandableListBase title="Item">
+			<ExpandableListBase title="Item" open>
 				{children}
 			</ExpandableListBase>
 		);

packages/moonstone/Scrollable/Scrollable.js

@@ -440,6 +440,10 @@ class ScrollableBase extends Component {
 
 		forward('onKeyDown', ev, this.props);
 
+		if (isPageUp(keyCode) || isPageDown(keyCode)) {
+			ev.preventDefault();
+		}
+
 		this.animateOnFocus = true;
 
 		if (!repeat && this.hasFocus()) {

packages/moonstone/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@enact/moonstone",
-  "version": "2.2.1",
+  "version": "2.2.2",
   "description": "Large-screen/TV support library for Enact, containing a variety of UI components.",
   "main": "index.js",
   "scripts": {
@@ -28,10 +28,10 @@
     "extends": "enact/strict"
   },
   "dependencies": {
-    "@enact/core": "^2.2.1",
-    "@enact/i18n": "^2.2.1",
-    "@enact/spotlight": "^2.2.1",
-    "@enact/ui": "^2.2.1",
+    "@enact/core": "^2.2.2",
+    "@enact/i18n": "^2.2.2",
+    "@enact/spotlight": "^2.2.2",
+    "@enact/ui": "^2.2.2",
     "classnames": "^2.2.5",
     "eases": "^1.0.8",
     "invariant": "^2.2.2",

packages/sampler/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 The following is a curated list of changes in the Enact Sampler, newest changes on the top.
 
+## [2.2.2] - 2018-10-15
+
+No significant changes.
+
 ## [2.2.1] - 2018-10-09
 
 No significant changes.