WRR-12807: Fixed VirtualList to not abnormally scroll when `dataSiz…

…e` and `itemSizes` changed (#3300) * WRR-12807: Fixed `VirtualList` to not abnormally scroll when `dataSize` and `itemSizes` changed Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * fix typo Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected])
enactjs · Dec 6, 2024 · bf7e012 · bf7e012
1 parent dff9a46
commit bf7e012
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/ui/CHANGELOG.md b/packages/ui/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 The following is a curated list of changes in the Enact ui module, newest changes on the top.
 
+## [unreleased]
+
+### Fixed
+
+- `ui/VirtualList` to not abnormally scroll when `dataSize` and `itemSizes` changed
+
 ## [5.0.0-alpha.3] - 2024-12-02
 
 ### Fixed

diff --git a/packages/ui/VirtualList/VirtualListBasic.js b/packages/ui/VirtualList/VirtualListBasic.js
@@ -407,7 +407,7 @@ class VirtualListBasic extends Component {
 			prevProps.overhang !== this.props.overhang ||
 			prevProps.spacing !== this.props.spacing ||
 			!equals(prevProps.itemSize, this.props.itemSize) ||
-			!shallowEqual(prevProps.itemSizes, this.props.itemSizes)
+			(!this.hasDataSizeChanged && !shallowEqual(prevProps.itemSizes, this.props.itemSizes))
 		) {
 			const {x, y} = this.getXY(this.scrollPosition, 0);