2.2.4 release

CHANGELOG.md

@@ -2,6 +2,13 @@
 
 The following is a curated list of changes in the Enact project, newest changes on the top.
 
+## [2.2.4] - 2018-10-29
+
+### Fixed
+
+- `moonstone/DayPicker` separator character used between selected days in the label in fa-IR locale
+- `moonstone/Scroller`, `moonstone/VirtualList.VirtualGridList`, and `moonstone/VirtualList.VirtualList` scrolling by voice commands in RTL locales
+
 ## [2.2.3] - 2018-10-22
 
 ### Fixed

lerna.json

@@ -1,6 +1,6 @@
 {
   "lerna": "2.8.0",
-  "version": "2.2.3",
+  "version": "2.2.4",
   "command": {
     "bootstrap": {
       "npmClientArgs": [

package.json

@@ -1,6 +1,6 @@
 {
   "name": "enact",
-  "version": "2.2.3",
+  "version": "2.2.4",
   "description": "Monorepo for all Enact front end libraries.",
   "private": true,
   "scripts": {

packages/core/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 The following is a curated list of changes in the Enact core module, newest changes on the top.
 
+## [2.2.4] - 2018-10-29
+
+No significant changes.
+
 ## [2.2.3] - 2018-10-22
 
 No significant changes.

packages/core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@enact/core",
-  "version": "2.2.3",
+  "version": "2.2.4",
   "description": "Enact is an open source JavaScript framework containing everything you need to create a fast, scalable mobile or web application.",
   "main": "index.js",
   "scripts": {

packages/i18n/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 The following is a curated list of changes in the Enact i18n module, newest changes on the top.
 
+## [2.2.4] - 2018-10-29
+
+No significant changes.
+
 ## [2.2.3] - 2018-10-22
 
 No significant changes.

packages/i18n/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@enact/i18n",
   "main": "./src/index.js",
-  "version": "2.2.3",
+  "version": "2.2.4",
   "description": "Internationalization support for Enact using iLib",
   "scripts": {
     "clean": "enact clean",
@@ -34,7 +34,7 @@
     "extends": "enact/strict"
   },
   "dependencies": {
-    "@enact/core": "^2.2.3",
+    "@enact/core": "^2.2.4",
     "prop-types": "^15.6.0",
     "ramda": "^0.24.1",
     "react": "^16.3.2",

packages/moonstone/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 The following is a curated list of changes in the Enact moonstone module, newest changes on the top.
 
+## [2.2.4] - 2018-10-29
+
+### Fixed
+
+- `moonstone/DayPicker` separator character used between selected days in the label in fa-IR locale
+- `moonstone/Scroller`, `moonstone/VirtualList.VirtualGridList`, and `moonstone/VirtualList.VirtualList` scrolling by voice commands in RTL locales
+
 ## [2.2.3] - 2018-10-22
 
 ### Fixed

packages/moonstone/Checkbox/Checkbox.js

@@ -21,7 +21,7 @@ import css from './Checkbox.less';
 /**
  * A checkbox component, ready to use in Moonstone applications.
  *
- * `Checkbox` may be used independently to represent a togglable state but is more commonly used as
+ * `Checkbox` may be used independently to represent a toggleable state but is more commonly used as
  * part of [CheckboxItem]{@link moonstone/CheckboxItem}.
  *
  * Usage:

packages/moonstone/DayPicker/DayPicker.js

@@ -14,6 +14,7 @@
  */
 
 import kind from '@enact/core/kind';
+import {I18nContextDecorator} from '@enact/i18n/I18nDecorator';
 import Changeable from '@enact/ui/Changeable';
 import Pure from '@enact/ui/internal/Pure';
 import compose from 'ramda/src/compose';
@@ -120,6 +121,7 @@ const DayPickerDecorator = compose(
 	Pure,
 	Expandable,
 	Changeable({change: 'onSelect', prop: 'selected'}),
+	I18nContextDecorator({localeProp: 'locale'}),
 	DaySelectorDecorator
 );
 

packages/moonstone/DaySelector/DaySelectorDecorator.js

@@ -240,6 +240,11 @@ const DaySelectorDecorator = hoc((config, Wrapped) => {	// eslint-disable-line n
 			}
 
 			const type = this.calcSelectedDayType(selected);
+			const format = (list) => {
+				let separator = this.props.locale === 'fa-IR' ? '، ' : ', ';
+
+				return list.join(separator);
+			};
 
 			switch (type) {
 				case SELECTED_DAY_TYPES.EVERY_DAY :
@@ -249,7 +254,7 @@ const DaySelectorDecorator = hoc((config, Wrapped) => {	// eslint-disable-line n
 				case SELECTED_DAY_TYPES.EVERY_WEEKDAY :
 					return everyWeekdayText;
 				case SELECTED_DAY_TYPES.SELECTED_DAYS :
-					return selected.sort().map((dayIndex) => selectDayStrings[dayIndex]).join(', ');
+					return format(selected.sort().map((dayIndex) => selectDayStrings[dayIndex]));
 				case SELECTED_DAY_TYPES.SELECTED_NONE :
 					return '';
 			}

packages/moonstone/FormCheckboxItem/FormCheckboxItem.js

@@ -1,5 +1,5 @@
 /**
- * Provides Moonstone styled form item component and interactive togglable checkbox.
+ * Provides Moonstone styled form item component and interactive toggleable checkbox.
  *
  * @example
  * <FormCheckboxItem>A Checkbox for a form</FormCheckboxItem>

packages/moonstone/RadioItem/RadioItem.js

@@ -1,5 +1,5 @@
 /**
- * Provides a Moonstone-themed Item component and interactive togglable radio icon.
+ * Provides a Moonstone-themed Item component and interactive toggleable radio icon.
  *
  * @example
  * <RadioItem>Item</RadioItem>

packages/moonstone/Scrollable/Scrollable.js

@@ -687,12 +687,21 @@ class ScrollableBase extends Component {
 
 	onVoice = (e) => {
 		const
-			scroll = e && e.detail && e.detail.scroll,
+			isHorizontal = this.props.direction === 'horizontal',
 			isRtl = this.uiRef.state.rtl,
 			{scrollTop, scrollLeft} = this.uiRef,
 			{maxLeft, maxTop} = this.uiRef.getScrollBounds(),
 			verticalDirection = ['up', 'down', 'top', 'bottom'],
-			horizontalDirection = ['left', 'right', 'leftmost', 'rightmost'];
+			horizontalDirection = isRtl ? ['right', 'left', 'rightmost', 'leftmost'] : ['left', 'right', 'leftmost', 'rightmost'],
+			movement = ['previous', 'next', 'first', 'last'];
+
+		let
+			scroll = e && e.detail && e.detail.scroll,
+			index = movement.indexOf(scroll);
+
+		if (index > -1) {
+			scroll = isHorizontal ? horizontalDirection[index] : verticalDirection[index];
+		}
 
 		this.voiceControlDirection = verticalDirection.includes(scroll) && 'vertical' || horizontalDirection.includes(scroll) && 'horizontal' || null;
 

packages/moonstone/Scrollable/ScrollableNative.js

@@ -761,12 +761,21 @@ class ScrollableBaseNative extends Component {
 
 	onVoice = (e) => {
 		const
-			scroll = e && e.detail && e.detail.scroll,
+			isHorizontal = this.props.direction === 'horizontal',
 			isRtl = this.uiRef.state.rtl,
 			{scrollTop, scrollLeft} = this.uiRef,
 			{maxLeft, maxTop} = this.uiRef.getScrollBounds(),
 			verticalDirection = ['up', 'down', 'top', 'bottom'],
-			horizontalDirection = ['left', 'right', 'leftmost', 'rightmost'];
+			horizontalDirection = isRtl ? ['right', 'left', 'rightmost', 'leftmost'] : ['left', 'right', 'leftmost', 'rightmost'],
+			movement = ['previous', 'next', 'first', 'last'];
+
+		let
+			scroll = e && e.detail && e.detail.scroll,
+			index = movement.indexOf(scroll);
+
+		if (index > -1) {
+			scroll = isHorizontal ? horizontalDirection[index] : verticalDirection[index];
+		}
 
 		this.voiceControlDirection = verticalDirection.includes(scroll) && 'vertical' || horizontalDirection.includes(scroll) && 'horizontal' || null;
 

packages/moonstone/SelectableItem/SelectableIcon.js

@@ -1,6 +1,6 @@
 // Not actually an exported module
 /*
- * Provides Moonstone-themed circle component and interactive togglable capabilities.
+ * Provides Moonstone-themed circle component and interactive toggleable capabilities.
  *
  * @module moonstone/SelectableIcon
  * @exports SelectableIcon

packages/moonstone/SwitchItem/SwitchItem.js

@@ -1,5 +1,5 @@
 /**
- * Provides Moonstone-themed item component and interactive togglable switch.
+ * Provides Moonstone-themed item component and interactive toggleable switch.
  *
  * @example
  * <SwitchItem>

packages/moonstone/ToggleIcon/ToggleIcon.js

@@ -1,20 +1,29 @@
 /**
- * Provides Moonstone-themed Icon component with interactive togglable capabilities.
+ * Provides Moonstone-themed Icon component with interactive toggleable capabilities.
  *
- * Moonstone components that uses `ToggleIcon`:
+ * `ToggleIcon` does not implement a visual change when a user interacts with the control and must
+ * be customized by the consumer using [css className
+ * overrides]{@link ui/ToggleIcon.ToggleIconBase.css}.
+ *
+ * Often, an [Icon value]{@link moonstone/Icon.Icon} is passed as `children` to represent the
+ * selected state but is not required. Omitting `children` allows the consumer to implement more
+ * advanced approaches such as styling the `::before` and `::after` pseudo-elements to save a DOM
+ * node.
+ *
+ * The following Moonstone components use `ToggleIcon`, and make good examples of various usages.
  *
  * * [Checkbox]{@link moonstone/Checkbox.Checkbox},
  * * [FormCheckbox]{@link moonstone/FormCheckbox.FormCheckbox},
  * * [Switch]{@link moonstone/Switch.Switch},
  * * [RadioItem]{@link moonstone/RadioItem.RadioItem}, and
  * * [SelectableItem]{@link moonstone/SelectableItem.SelectableItem}.
  *
- * @module moonstone/ToggleIcon
  * @example
- * <ToggleIcon
- * 	onToggle={(props)=> console.log(props.selected)}>
- * 	check
+ * <ToggleIcon onToggle={(props)=> console.log(props.selected)}>
+ *   check
  * </ToggleIcon>
+ *
+ * @module moonstone/ToggleIcon
  * @exports ToggleIcon
  * @exports ToggleIconBase
  * @exports ToggleIconDecorator

packages/moonstone/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@enact/moonstone",
-  "version": "2.2.3",
+  "version": "2.2.4",
   "description": "Large-screen/TV support library for Enact, containing a variety of UI components.",
   "main": "index.js",
   "scripts": {
@@ -28,10 +28,10 @@
     "extends": "enact/strict"
   },
   "dependencies": {
-    "@enact/core": "^2.2.3",
-    "@enact/i18n": "^2.2.3",
-    "@enact/spotlight": "^2.2.3",
-    "@enact/ui": "^2.2.3",
+    "@enact/core": "^2.2.4",
+    "@enact/i18n": "^2.2.4",
+    "@enact/spotlight": "^2.2.4",
+    "@enact/ui": "^2.2.4",
     "classnames": "^2.2.5",
     "eases": "^1.0.8",
     "invariant": "^2.2.2",

packages/sampler/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 The following is a curated list of changes in the Enact Sampler, newest changes on the top.
 
+## [2.2.4] - 2018-10-29
+
+No significant changes.
+
 ## [2.2.3] - 2018-10-22
 
 No significant changes.