Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy Scroller from Enact #2760

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ybsung
Copy link
Contributor

@ybsung ybsung commented Apr 24, 2020

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added / Resolution

Remove legacy scroller for moonstone compatibility
Rename ui/VirtualList.VirtualListBasic.js as ui/VirtualList.VirtualListBase.js
Rename ui/Scroller.ScrollerBasic.js as ui/Scroller.ScrollerBase.js

Links

Comments

Enact-DCO-1.0-Signed-off-by: YB Sung ([email protected])
@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #2760 into develop will increase coverage by 10.88%.
The diff coverage is 59.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2760       +/-   ##
============================================
+ Coverage    43.98%   54.86%   +10.88%     
============================================
  Files          155      149        -6     
  Lines         8085     6532     -1553     
  Branches      1980     1594      -386     
============================================
+ Hits          3556     3584       +28     
+ Misses        3398     2217     -1181     
+ Partials      1131      731      -400     
Impacted Files Coverage Δ
packages/ui/Scroller/Scroller.js 0.00% <ø> (ø)
packages/ui/Scroller/ScrollerBase.js 0.00% <0.00%> (ø)
packages/ui/VirtualList/VirtualList.js 80.00% <ø> (ø)
packages/ui/VirtualList/VirtualListBase.js 60.22% <60.22%> (ø)
packages/core/useHandlers/useHandlers.js 100.00% <0.00%> (ø)
packages/core/kind/kind.js 100.00% <0.00%> (+2.77%) ⬆️
packages/core/useClass/useClass.js 60.00% <0.00%> (+60.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46dc67a...bfa77c9. Read the comment docs.

Enact-DCO-1.0-Signed-off-by: YB Sung ([email protected])
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants