Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-109159: Allow iconProps prop in Button to pass it to the Icon #2787

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ybsung
Copy link
Contributor

@ybsung ybsung commented Jun 11, 2020

Checklist

  • I have read and understand the contribution guide

  • A CHANGELOG entry is included

  • At least one test case is included for this feature or bug fix

  • Documentation was added or is not needed

  • This is an API breaking change

Issue Resolved / Feature Added

Need the way to pass Icon's prop though Button.

To flip an icon In RTL, we want to pass {flip: 'horizontal'} prop from Button to Icon.

Resolution

Support the iconProp in Button and pass it to the Icon.

Additional Considerations

Links

PLAT-109159
Related PR: enactjs/sandstone#438

Comments

Enact-DCO-1.0-Signed-off-by: YB Sung ([email protected])

ybsung added 2 commits June 11, 2020 13:38
Enact-DCO-1.0-Signed-off-by: YB Sung ([email protected])
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #2787 into develop will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2787      +/-   ##
===========================================
- Coverage    44.60%   44.59%   -0.01%     
===========================================
  Files          161      161              
  Lines         8134     8135       +1     
  Branches      1983     1983              
===========================================
  Hits          3628     3628              
- Misses        3382     3383       +1     
  Partials      1124     1124              
Impacted Files Coverage Δ
packages/ui/Button/Button.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7bbcea...0a08fd0. Read the comment docs.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants