Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-164: Remove direction module and use own function #3221

Closed
wants to merge 3 commits into from

Conversation

hong6316
Copy link
Contributor

@hong6316 hong6316 commented Mar 28, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

When checking WRP-21845, the below issue has been occurred while updating direction ^1.0.4 → ^2.0.1
(details: check WRQ-164)
The API we use in the direction module is simple, so we only need to import the parts we need.

Resolution

Remove direction module and use own function

Additional Considerations

History of why direction is used: #1378 (comment)

Links

WRQ-164

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong ([email protected])

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.37%. Comparing base (22d1301) to head (edcaaae).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3221   +/-   ##
========================================
  Coverage    82.36%   82.37%           
========================================
  Files          155      155           
  Lines         7208     7211    +3     
  Branches      1907     1907           
========================================
+ Hits          5937     5940    +3     
  Misses         999      999           
  Partials       272      272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hong6316 hong6316 closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant