WRQ-20844: Fixed React 18.3 warnings in enact/ui/Layout #3239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
…y in sampler Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3239 +/- ##
========================================
Coverage 82.42% 82.42%
========================================
Files 156 156
Lines 7214 7215 +1
Branches 1912 1912
========================================
+ Hits 5946 5947 +1
Misses 997 997
Partials 271 271 ☔ View full report in Codecov by Sentry. |
…into feature/WRQ-20844
adrian-cocoara-lgp
approved these changes
May 22, 2024
juwonjeong
reviewed
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
In React 18.3, There are warnings for key spreading. The warning is reproducible when using agate/LabeledIconButton
Resolution
Passed key attribute directly to JSX without using spread in enact/ui/Layout/Cell
Additional Considerations
Links
WRQ-19328
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian ([email protected])