WRQ-242: Adding 'browser', 'node', and 'jest' environment in 'env'

[hong6316]

Checklist

• I have read and understand the contribution guide
• A CHANGELOG entry is included
• At least one test case is included for this feature or bug fix
• I have run automated CLI testing and it is passed
• Documentation was added or is not needed
• This is an API breaking change

Issue Resolved / Feature Added

In order to provide the global variable of the browser, node, and jest, environments must be added to the env setting in the config file.
An environment provides predefined global variables.

• env: https://eslint.org/docs/latest/use/configure/language-options#specifying-environments
  • global variables in env
    • browser: https://github.com/sindresorhus/globals/blob/9b903064b5842a3231549d3767dbfddb463c1c0d/globals.json#L363-L1127
    • node: https://github.com/sindresorhus/globals/blob/9b903064b5842a3231549d3767dbfddb463c1c0d/globals.json#L1231-L1302
    • jest: https://github.com/sindresorhus/globals/blob/9b903064b5842a3231549d3767dbfddb463c1c0d/globals.json#L1425-L1441

Resolution

Adding browser, node, and jest environment in env

Additional Considerations

• Change es6 -> es2015 (reason: sindresorhus/globals@baccc2a)
• index.js: Allowing some var names in no-shadow rule for enact samples & sampler
• strict.js: Allowing some var names in no-shadow rule for enact frameworks

Links

WRQ-242

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong ([email protected])

[0x64]

If we want to release including worker and the new environments altogether, changelogs need to be merged in a single line.

[hong6316]

Agree

[0x64]

What is the ordering rule inside env block?

[hong6316]

There were no ordering rules(and simply in the order of the added date), but if needs, alphabetical order seems appropriate.
Should I? Either is fine to me.