WRR-1011: Fixed eslint and prettier lint rules to not conflict
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nflicts with 'prettier' rules
5 tasks
MikyungKim
reviewed
Dec 31, 2024
| 'warn', | ||
| { | ||
| anonymous: 'always', | ||
| named: 'never', |
There was a problem hiding this comment.
I think this change will make huge lint warnings from our repos which use enact lint.
If I use this branch and do npm run lint from sandstone for example, I get tons of warnings like
...
/sandstone/WizardPanels/Panel.js
15:19 warning Unexpected space before function parentheses @stylistic/js/space-before-function-paren
/sandstone/internal/$L/$L.js
14:22 warning Unexpected space before function parentheses @stylistic/js/space-before-function-paren
25:25 warning Unexpected space before function parentheses @stylistic/js/space-before-function-paren
47:24 warning Unexpected space before function parentheses @stylistic/js/space-before-function-paren
...
I don't think this is a good idea to solve the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
An issue has been signaled in storybook-utils repo. The
eslintrules andprettierlint rules are opposite for applying spacing after function keyword. Currently a workaround was applied to avoid the conflicts.Resolution
I have adjusted '@stylistic/js/space-before-function-paren' rule to avoid conflicts with
prettierrules.Additional Considerations
Links
WRR-1011
Comments
Enact-DCO-1.0-Signed-off-by: Stanca Pop ([email protected])