Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-5260: Convert Slider/SlideBehaviourDecorator to functional component #1728

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

paul-beldean-lgp
Copy link
Contributor

@paul-beldean-lgp paul-beldean-lgp commented Oct 18, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Slider/SlideBehaviourDecorator was a class component.

Resolution

Converted Slider/SlideBehaviourDecorator to be functional component instead of class component.

Additional Considerations

Links

WRR-5260

Comments

Enact-DCO-1.0-Signed-off-by: Paul Beldean [email protected]

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.89%. Comparing base (de22a0f) to head (2d47f7a).

Files with missing lines Patch % Lines
Slider/SliderBehaviorDecorator.js 96.22% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1728      +/-   ##
===========================================
- Coverage    80.90%   80.89%   -0.02%     
===========================================
  Files          148      148              
  Lines         6678     6673       -5     
  Branches      1989     1989              
===========================================
- Hits          5403     5398       -5     
  Misses         968      968              
  Partials       307      307              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Slider/SliderBehaviorDecorator.js Outdated Show resolved Hide resolved
Slider/SliderBehaviorDecorator.js Outdated Show resolved Hide resolved
Slider/SliderBehaviorDecorator.js Outdated Show resolved Hide resolved
Slider/SliderBehaviorDecorator.js Outdated Show resolved Hide resolved
Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Slider/SliderBehaviorDecorator.js Outdated Show resolved Hide resolved
Slider/SliderBehaviorDecorator.js Outdated Show resolved Hide resolved
Slider/SliderBehaviorDecorator.js Outdated Show resolved Hide resolved
Slider/SliderBehaviorDecorator.js Outdated Show resolved Hide resolved
Slider/SliderBehaviorDecorator.js Outdated Show resolved Hide resolved
Slider/SliderBehaviorDecorator.js Outdated Show resolved Hide resolved
Slider/SliderBehaviorDecorator.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants