Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-11058: Update editable scroller focus behavior to match the latest UX #1787

Open
wants to merge 6 commits into
base: release/2.9.x.develop
Choose a base branch
from

Conversation

juwonjeong
Copy link
Contributor

@juwonjeong juwonjeong commented Dec 17, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Focus behavior of the editable scroller is updated
(1) After moving focus to the top button(item is not selected), focus will be moved by pressing the ← or → keys
241217_focusbehavior_1
(2) After entering the item edit mode, item can be moved by pressing the ← or → keys while focusing on the top button
241217_focusbehavior_2

Resolution

Fix handleKeyDownCapture to move focus according to updated UX guide

Additional Considerations

(1) To fix the issue as the gif below, I added 6084876 commit.
241217_lastInputType
The issue occurs when focus moves to the hide button, scroll event occurred and then handleMoveItemsByScroll executed.
I added to set lastInputType to key to prevent handleMoveItemsByScroll from being executed.

(2) Since there is no guide for these cases, I implemented it as follows.
241217_edge_1
241217_edge_2
241217_edge_3
241217_edge_4

(3) I added 92fd7fc commit to fix the a11y issue which caused by the logic which manually focus the item.

Links

WRR-11058

Comments

Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (4ad46d0) to head (92fd7fc).
Report is 1 commits behind head on release/2.9.x.develop.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           release/2.9.x.develop    #1787   +/-   ##
======================================================
  Coverage                  80.91%   80.91%           
======================================================
  Files                        148      148           
  Lines                       6697     6697           
  Branches                    1995     1995           
======================================================
  Hits                        5419     5419           
  Misses                       970      970           
  Partials                     308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
@0x64
Copy link
Member

0x64 commented Jan 7, 2025

Loos good to me. Let's refine lastInputType and lastInputDirection so that the logic would not lead misunderstanding on later visit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants