Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright years in README.md file #1795

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
d0650cf
Merge branch 'master' into develop
enact-bot Dec 2, 2024
313bc48
WRR-9115: `Scroller`: Fixed to focus properly when the spottable node…
mmyelyn Dec 2, 2024
3e51a0b
WRR-6385: Converted sandstone/TimePicker/TimePickerBase HourPicker to…
paul-beldean-lgp Dec 4, 2024
2ae1394
WRR-11077: Fixed Scroller to prevent the native scrolling behavior ca…
juwonjeong Dec 5, 2024
9faf7a6
WRR-12961: Add new icon calibration and update font file (#1771)
juwonjeong Dec 6, 2024
b06e704
WRR-12807: Added VirtualList qa-sampler for changing `dataSize` and `…
MikyungKim Dec 6, 2024
5e803d7
WRR-3979: Updated storybook to 8.4 (#1739)
daniel-stoian-lgp Dec 9, 2024
4e3182d
WRR-10094: Convert Dropdown/DropDownList to functional component (#1749)
alexandrumorariu Dec 12, 2024
5b666e4
WRR-11059: update TabLayout storybook sample's icons (#1773)
SkylerBaek Dec 12, 2024
6227c36
WRR-14027: Added UI test when PageViews' autoFocus is 'none' (#1781)
mmyelyn Dec 16, 2024
248ca04
WRR-10797: Fixed typos and grammar errors (#1758)
daniel-stoian-lgp Dec 16, 2024
ec5e856
WRR-10797: Replaced unsafe URLs (#1761)
daniel-stoian-lgp Dec 17, 2024
c06afdd
WRR-621: Removed unused modules in sampler (#1779)
stanca-pop-lgp Dec 17, 2024
a76e348
WRR-10797 - Fixed JSDoc issues (#1762)
daniel-stoian-lgp Dec 17, 2024
1107ba3
replaced deprecated functions and fixed function call params (#1763)
daniel-stoian-lgp Dec 17, 2024
0bf8a28
WRR-12149: Convert sandstone/internal/WindowEventable to functional c…
alexandrumorariu Dec 19, 2024
7ec3f80
WRR-387: `Panels`: Updated documentation for arranger (#1752)
vJIYEv Dec 19, 2024
de22a0f
WRR-8543: Fixed editable `Scroller` not to use static classname (#1767)
MikyungKim Dec 19, 2024
2e31530
WRR-12139: Convert sandstone/ThemeDecorator/I18nFontDecorator to func…
alexandrumorariu Dec 23, 2024
af6becb
WRR-1039: Removed animation and shadow effects with cli `--no-animati…
vJIYEv Dec 24, 2024
49b1227
WRR-12677: Fix node_js to use 'lts/*' and 'node' on travis (#1785)
hong6316 Dec 27, 2024
af23bc4
WRR-9415: remove vendor-opacity mixin that is only for legacy IE from…
SkylerBaek Dec 30, 2024
79850bc
WRR-1063: Added a QA sampler for `Spotlight.focus` with `preventScrol…
SkylerBaek Dec 31, 2024
d6a15c4
WRR-14337: Fix editable scroller to enable hoverToScroll via touch (…
juwonjeong Jan 2, 2025
dfe840d
WRR-4833: Make pageIndicatorPosition prop in PageViews component publ…
juwonjeong Jan 3, 2025
a82077e
WRR-287: Replace CSS variables having R,G,B formats with standard #RG…
SkylerBaek Jan 3, 2025
53b8e57
update license
invalid-email-address Jan 4, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
### Checklist

* [ ] I have read and understand the [contribution guide](http://enactjs.com/docs/developer-guide/contributing/)
* [ ] A [CHANGELOG entry](http://enactjs.com/docs/developer-guide/contributing/changelogs/) is included
* [ ] I have read and understand the [contribution guide](https://enactjs.com/docs/developer-guide/contributing/)
* [ ] A [CHANGELOG entry](https://enactjs.com/docs/developer-guide/contributing/changelogs/) is included
* [ ] At least one test case is included for this feature or bug fix
* [ ] Documentation was added or is not needed
* [ ] This is an API breaking change
Expand Down
7 changes: 4 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
dist: jammy
language: node_js
node_js:
- 21
- lts/*
- node
sudo: false
before_install:
- curl -fsSL https://www.mongodb.org/static/pgp/server-4.4.asc | sudo gpg -o /usr/share/keyrings/mongodb-server-4.4.gpg --dearmor
- echo "deb [ arch=amd64,arm64 signed-by=/usr/share/keyrings/mongodb-server-4.4.gpg ] https://repo.mongodb.org/apt/ubuntu focal/mongodb-org/4.4 multiverse" | sudo tee /etc/apt/sources.list.d/mongodb-org-4.4.list
- sudo apt-get update
- sudo apt-get install build-essential libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev
install:
Expand All @@ -18,12 +17,14 @@ install:
- popd
- git clone --branch=develop --depth 1 https://github.com/enactjs/enact ../enact
- pushd ../enact
- npm uninstall @enact/ui-test-utils --prefix packages/i18n
- npm install
- npm run lerna exec -- --ignore enact-sampler --concurrency 1 -- npm --no-package-lock install
- npm run lerna exec -- --ignore enact-sampler --concurrency 1 -- npm --no-package-lock link
- npm run interlink
- popd
- rm -fr node_modules/@enact
- npm uninstall @enact/ui-test-utils
- npm install
- enact link
script:
Expand Down
14 changes: 9 additions & 5 deletions Alert/Alert.module.less
Original file line number Diff line number Diff line change
Expand Up @@ -138,23 +138,27 @@

/* Override colors inside overlay type Alert */
--sand-bg-color: @sand-alert-overlay-bg-color;
--sand-text-color-rgb: @sand-alert-overlay-text-color-rgb;
--sand-text-color: @sand-alert-overlay-text-color;
--sand-text-sub-color: @sand-alert-overlay-text-sub-color;
--sand-focus-text-color: @sand-alert-overlay-focus-text-color;
--sand-disabled-selected-color: @sand-alert-overlay-disabled-selected-color;
--sand-disabled-selected-bg-color: @sand-alert-overlay-disabled-selected-bg-color;
--sand-disabled-selected-focus-color: @sand-alert-overlay-disabled-selected-focus-color;
--sand-disabled-selected-focus-bg-color: @sand-alert-overlay-disabled-selected-focus-bg-color;
--sand-progress-color-rgb: @sand-alert-overlay-progress-color-rgb;
--sand-progress-bg-color-rgb: @sand-alert-overlay-progress-bg-color-rgb;
--sand-progress-bg-color-alpha: @sand-alert-overlay-progress-bg-color-alpha;
--sand-progress-color: @sand-alert-overlay-progress-color;
--sand-progress-bg-color: @sand-alert-overlay-progress-bg-color;
--sand-progress-bg-color-opacity: @sand-alert-overlay-progress-bg-color-opacity;
--sand-checkbox-color: @sand-alert-overlay-checkbox-color;
--sand-checkbox-disabled-selected-text-color: @sand-alert-overlay-checkbox-disabled-selected-text-color;
--sand-formcheckboxitem-focus-text-color: @sand-alert-overlay-formcheckboxitem-focus-text-color;
--sand-item-disabled-focus-bg-color: @sand-alert-overlay-item-disabled-focus-bg-color;

background-color: rgb(@sand-alert-overlay-bg-color-rgb, @sand-alert-overlay-bg-color-opacity);
background-color: ~"color(from" @sand-alert-overlay-bg-color ~"srgb r g b /" @sand-alert-overlay-bg-color-opacity ~")";
box-shadow: @sand-alert-overlay-shadow;

:global(.noAnimation) & {
box-shadow: none;
}
}
});
}
41 changes: 41 additions & 0 deletions Button/Button.module.less
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,47 @@
});
}

:global(.noAnimation) & {
.focus({
.bg {
.sand-button-focus-bg-colors(@shadow: {
box-shadow: none;
});
}

&.focusExpand {
.bg {
.sand-bg-colors({
transform: none;
});
}

&.small .bg {
.sand-bg-colors({
transform: none;
});
}

&.pressed,
&:active {
.bg {
.sand-bg-colors({
transform: none;
});
}

&.small {
.bg {
.sand-bg-colors({
transform: none;
});
}
}
}
}
});
}

.sand-disabled({
.client {
.sand-disabled-colors();
Expand Down
18 changes: 17 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,22 @@

The following is a curated list of changes in the Enact sandstone module, newest changes on the top.

## [unreleased]

### Added

- `sandstone/Icon` supported icon list, adding new icon `calibration`
- `sandstone/Pageviews` `pageIndicatorPosition` prop to set the position of the page indicator

### Changed

- CSS variables with suffix '-rgb' to without suffix and its value to hex format

### Fixed

- `sandstone/Scroller` to focus properly when the spottable node is bigger than the size of viewport by voice control
- `sandstone/Scroller` to prevent the native scrolling behavior caused by keydown events when a popup is open

## [3.0.0-alpha.3] - 2024-12-02

### Added
Expand Down Expand Up @@ -309,7 +325,7 @@ No significant changes.

### Fixed

- `sandstone/Dropdown' to focus properly the first option and the last option via page up and page down
- `sandstone/Dropdown` to focus properly the first option and the last option via page up and page down
- `sandstone/QuickGuidePanels` to not lose focus when the last view is displayed

## [2.7.5] - 2023-08-04
Expand Down
2 changes: 1 addition & 1 deletion Checkbox/Checkbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ const CheckboxBase = kind({

computed: {
className: ({indeterminate, selected, standalone, styler}) => styler.append({selected, standalone, indeterminate}),
children: ({indeterminate, indeterminateIcon, children}) => (indeterminate ? indeterminateIcon : children) // This controls which icon to use, an not that icon's visual presence.
children: ({indeterminate, indeterminateIcon, children}) => (indeterminate ? indeterminateIcon : children) // This controls which icon to use, and not that icon's visual presence.
},

render: ({children, css, disabled, selected, ...rest}) => {
Expand Down
18 changes: 17 additions & 1 deletion Checkbox/Checkbox.module.less
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
line-height: 0;

.icon {
margin: 0; // Needed to apply here insetad of on `.checkbox` due to .icon.size precedence :(
margin: 0; // Needed to apply here instead of on `.checkbox` due to .icon.size precedence :(
border-radius: @sand-checkbox-border-radius;
position: relative;
text-align: center;
Expand Down Expand Up @@ -171,6 +171,14 @@
@checkbox-focus();
});

:global(.noAnimation) & {
.focus({
.bg {
box-shadow: none;
}
})
}

// Disabled
.sand-disabled({
.icon {
Expand All @@ -195,6 +203,14 @@
@checkbox-focus();
}
});

:global(.noAnimation) & {
.focus({
& .checkbox .bg {
box-shadow: none;
}
});
}
});

.applySkins({
Expand Down
2 changes: 1 addition & 1 deletion ContextualMenuDecorator/ContextualMenuDecorator.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const ScrollingRepeater = ({className, ...rest}) => (
);

const ContextualMenuDecoratorBase = hoc(defaultConfig, (config, Wrapped) => {
// we might not need Skinnable at all here. If we want to skin the popup and it's defined as a
// we might not need Skinnable at all here. If we want to skin the popup, and it's defined as a
// private component in this module, we can wrap it with skinnable and style it as needed there.
const Component = Skinnable(
ContextualPopupDecorator(
Expand Down
4 changes: 4 additions & 0 deletions ContextualPopupDecorator/ContextualPopup.module.less
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@
background-color: @sand-contextualpopup-bg-color;
border-radius: @sand-contextualpopup-border-radius;
box-shadow: @sand-contextualpopup-shadow;

:global(.noAnimation) & {
box-shadow: none;
}
}

.arrow {
Expand Down
4 changes: 2 additions & 2 deletions ContextualPopupDecorator/ContextualPopupDecorator.js
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ const Decorator = hoc(defaultConfig, (config, Wrapped) => {
snapshot.shouldSpotActivator = (
// isn't set
!current ||
// is on the activator and we want to re-spot it so a11y read out can occur
// is on the activator, and we want to re-spot it so a11y read out can occur
current === prevState.activator ||
// is within the popup
this.containerNode.contains(current)
Expand Down Expand Up @@ -358,7 +358,7 @@ const Decorator = hoc(defaultConfig, (config, Wrapped) => {
}

generateId = () => {
return Math.random().toString(36).substr(2, 8);
return Math.random().toString(36).substring(2, 10);
};

getContainerNodeWidth () {
Expand Down
2 changes: 1 addition & 1 deletion DatePicker/DatePicker.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ const DatePicker = Pure(
* @function
* @memberof sandstone/DatePicker
* @param {Date} date `Date` to convert
* @returns {String?} Converted date or `null` if `date` is invalid
* @returns {String|null} Converted date or `null` if `date` is invalid
*/
const dateToLocaleString = (date) => {
if (!date) {
Expand Down
2 changes: 1 addition & 1 deletion DayPicker/DayPicker.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const DayPickerBase = kind({
disabled: PropTypes.bool,

/**
* Called when an day is selected or unselected.
* Called when a day is selected or unselected.
*
* The event payload will be an object with the following members:
* * `selected` - An array of numbers representing the selected days, 0 indexed where Sunday
Expand Down
2 changes: 1 addition & 1 deletion DayPicker/DaySelectorDecorator.js
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ const DaySelectorDecorator = hoc((config, Wrapped) => {
locale: PropTypes.string,

/**
* Called when an day is selected or unselected.
* Called when a day is selected or unselected.
*
* The event payload will be an object with the following members:
* * `selected` - An array of numbers representing the selected days, 0 indexed
Expand Down
2 changes: 1 addition & 1 deletion DayPicker/tests/DayPicker-specs.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('DayPicker', () => {
// We need to change the locale to firstDayOfWeek !== 0.
// If firstDayOfWeek === 0, the number type check conditional statement
// is skipped due to the fast execution path of localizeSelected(), which
// reduces code coverage..
// reduces code coverage.
ilib.setLocale('es-ES');

render(<DayPicker locale="es-ES" selected={1} />);
Expand Down
Loading
Loading