Add JSON Marshalling support to device and entity #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both DeviceInterface and EntityInterface implementations (e.g. DeviceRemoteInterface and EntityRemoteInterface) are used as arguments in API calls and return values. When these API calls are used via interprocess communication protocols based on JSON, then the easiest way is to convert them into their addresses to be identified. This change adds support for this need.
|
This looks useful, I'll check out if EntityInterface/DeviceInterface would need to mention that they extend json.Marshaler or if that gets picked up automatically next week. |
|
So I've tested, and this does just work without needing to explicitly add json.Marshaler to any of the interfaces. |
|
Thanks for verifying it @sthelen-enqs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both DeviceInterface and EntityInterface implementations (e.g. DeviceRemoteInterface and EntityRemoteInterface) are used as arguments in API calls and return values.
When these API calls are used via interprocess communication protocols based on JSON, then the easiest way is to convert them into their addresses to be identified.
This change adds support for this need.