Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recommendation for DRF Docs #6580

Merged
merged 1 commit into from
May 3, 2019
Merged

Conversation

AartGoossens
Copy link
Contributor

Description

Since DRF Docs is not compatible with the latest version of DRF (or Django?; related issue: manosim/django-rest-framework-docs#180) and the latest release of DRF Docs is almost 3 years ago I suggest to remove the recommendation for this package.

Copy link
Member

@rpkilby rpkilby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AartGoossens. I would recommend just wholly removing drf-docs from the documentation, as it's definitely outdated (hasn't been updated in ~2 years, and doesn't support any modern versions of Django).

@AartGoossens
Copy link
Contributor Author

Hi @rpkilby. Thanks for leaving a comment. Wholly removing it seemed a bit harsh at first but makes sense since there hasn't been any activity in the past 3 years. Will update the PR.

Since DRF Docs is not compatible with the latest version of DRF (or Django?; related issue: manosim/django-rest-framework-docs#180) and the latest release is almost 3 years ago I suggest to remove the recommendation for this package.
@rpkilby
Copy link
Member

rpkilby commented Apr 19, 2019

And of course, if the project gains a new maintainer, always happy to add it back to the list.

@rpkilby rpkilby self-requested a review April 19, 2019 21:23
@AartGoossens
Copy link
Contributor Author

Hi @rpkilby do I need to do something else to get this PR merged? Or is it just waiting for the right moment? :)

@rpkilby
Copy link
Member

rpkilby commented May 3, 2019

Nope, this is good to go - just slipped under the radar. GitHub's email notifications use image loading to automatically mark a notification as read. However, the iOS gmail app's push notifications will automatically loads images, erroneously marking the notification as read. ugh.

Thanks again!

@rpkilby rpkilby merged commit 0f819d8 into encode:master May 3, 2019
terencehonles pushed a commit to terencehonles/django-rest-framework that referenced this pull request Oct 8, 2020
Since DRF Docs is not compatible with the latest version of DRF (or Django?; related issue: manosim/django-rest-framework-docs#180) and the latest release is almost 3 years ago I suggest to remove the recommendation for this package.
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
Since DRF Docs is not compatible with the latest version of DRF (or Django?; related issue: manosim/django-rest-framework-docs#180) and the latest release is almost 3 years ago I suggest to remove the recommendation for this package.
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
Since DRF Docs is not compatible with the latest version of DRF (or Django?; related issue: manosim/django-rest-framework-docs#180) and the latest release is almost 3 years ago I suggest to remove the recommendation for this package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants