-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add socks5h proxy support #3178
Conversation
In some case socks5h is needed to resolve the hostname. Signed-off-by: bin liu <[email protected]>
|
@T-256 Indeed I run into a complexity case that socks5 not work: 12:39:33-bin~/tmppp\ -> export https_proxy=socks5h://127.0.0.1:15666
12:39:49-bin~/tmppp\ -> curl -I https://twitter.com
HTTP/2 403
date: Fri, 26 Apr 2024 04:39:51 GMT
server: tsa_p
x-powered-by: Express
... ...
12:39:51-bin~/tmppp\ -> export https_proxy=socks5://127.0.0.1:15666
12:39:56-bin~/tmppp\ -> curl -I https://twitter.com
curl: (35) LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to twitter.com:443 And my code with
My code using both requests and httpx, it is not controlled by me, but be the packages that I'm using directly. So let httpx to support socks5h is the simplest way for my case. |
Thanks, yep we probably should have Have you tested the above? I don't think it'll work, although you'll be able to pass Here's where you'll actually need to start on this...
|
Hello @tomchristie! I am also running into this issue, i.e. lack of |
Hi @tomchristie - firstly, thanks so much for all the work you've done on this project. We sure use the library a lot at $DAYJOB. Also - I'd be happy to pitch in $250 support to the project if we could get socks5h support merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, thanks! Does also need an httpcore
release in order to work all the way through.
link from #3386 |
When will the change for httpx and http core release to pip? |
In some case socks5h is needed to resolve the hostname.
Summary
add socks5h proxy support.
Checklist